Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email )
Change subject: V1.2: Add new fields to ProfileInfo list ......................................................................
Patch Set 1:
(3 comments)
File src/ipa/libipa/es10c_get_prfle_info.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/2247934f_d9252347?... : PS1, Line 78: if (conv_req && conv_req->fallback_attribute_removed) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/8dc9f3f6_a02c5a59?... : PS1, Line 109: struct ipa_es10c_get_prfle_info_req *conv_get_prfle_info_req(const struct ipa_es10c_get_prfle_info_req *req) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/d5fb15a4_452e81f6?... : PS1, Line 110: uint8_t default_tags[] = { 0x5A, 0x4F, 0x9F, 0x70, 0x91, 0x92, 0x95, 0x9F,0x7B, 0x9F,0x26, 0x9F,0x67 }; space required after that ',' (ctx:VxV)