Attention is currently required from: pespin. bucketking657 has posted comments on this change by bucketking657. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email ) Change subject: sgsn_libgtp: encode IMEISV via a local LV buffer ...................................................................... Patch Set 3: (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/44150/comment/2da08f67_f8b9b030?usp... : PS1, Line 306: gsm48_encode_bcd_number(&pdp->imeisv.v[0], 9, 0, mmctx->imei);
This is all imho a bit clunky, since we are encoding LV into a buffer which expects to only have V, […] ok, no problem. Reworked as suggested in PS2 I added a log message when encoding fails, follows same log pattern as other encoding failures within osmo-sgsn in PS3 (e.g. the IMEI encoding in vlr.c).
-- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/44150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c Gerrit-Change-Number: 44150 Gerrit-PatchSet: 3 Gerrit-Owner: bucketking657 <joshuashilts@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 19 Nov 2026 22:56:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>