Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email )
Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ......................................................................
Patch Set 8:
(13 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/537375f3_fb79e5ef?usp... : PS8, Line 2637: if (mmctx) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/63ef2c21_2e0786b4?usp... : PS8, Line 2666: if (!mme) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/8beaf4ef_298f49f1?usp... : PS8, Line 2696: } else { else is not generally useful after a break or return
File src/sgsn/gprs_rau_fsm.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/94c86c39_be2d1940?usp... : PS8, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/4e9911fd_40ff97d3?usp... : PS8, Line 190: if (!ggsn->gsn) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/5e2c3280_8956eaff?usp... : PS8, Line 909: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/9a5e4fee_3e6225f8?usp... : PS8, Line 914: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/177af86f_2dc654e6?usp... : PS8, Line 914: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/05c34cc8_b2232a4b?usp... : PS8, Line 1081: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n"); 'transfered' may be misspelled - perhaps 'transferred'?
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/1f324c93_f472be3b?usp... : PS8, Line 1121: if (buf_len <= 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/ce1332e6_22bd344a?usp... : PS8, Line 1135: // break; please, no space before tabs
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/6aa50d9d_96832d3a?usp... : PS8, Line 1374: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/f3cb4427_0c7e8085?usp... : PS8, Line 1384: if (rc) { braces {} are not necessary for single statement blocks