fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email ) Change subject: gsup_client: disable gen_server event tracing ...................................................................... gsup_client: disable gen_server event tracing Even with the logging level set to info, we're still seeing this: *DBG* gsup_client got call ... *DBG* gsup_client sent ... Those are messages printed by the gen_server module itself, and as it turns out we explicitly enable printing them by passing {debug, [trace]} to gen_server:start_link/3. This kind of logging is way too verbose and not useful for a regular user, so let's disable event tracing. Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Related: SYS#7415 --- M src/gsup_client.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 86a46d9..b4f7384 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -59,7 +59,7 @@ %% ------------------------------------------------------------------ start_link(ServerAddr, ServerPort, GsupName) -> - gen_server:start_link(?MODULE, [ServerAddr, ServerPort, GsupName], [{debug, [trace]}]). + gen_server:start_link(?MODULE, [ServerAddr, ServerPort, GsupName], []). %% ------------------------------------------------------------------ %% gen_server Function Definitions diff --git a/src/osmo_dia2gsup_sup.erl b/src/osmo_dia2gsup_sup.erl index 03c780d..dbb1ae6 100644 --- a/src/osmo_dia2gsup_sup.erl +++ b/src/osmo_dia2gsup_sup.erl @@ -12,7 +12,7 @@ % GSUP side HlrIp = application:get_env(osmo_dia2gsup, hlr_ip, "127.0.0.1"), HlrPort = application:get_env(osmo_dia2gsup, hlr_port, 4222), - Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], [{debug, [trace]}]], + Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], []], GsupChild = {gsup_client, {gen_server, start_link, Args}, permanent, 2000, worker, [gsup_client]}, % DIAMETER side DiaServer = {osmo_dia2gsup,{osmo_dia2gsup,start_link,[]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Gerrit-Change-Number: 39884 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>