falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email ) Change subject: e1_ts_stop: clear tx_started flag ...................................................................... e1_ts_stop: clear tx_started flag ts->raw.tx_started flag gets set in the channelized mux process when bytes begin arriving from the raw TS client application. However, there is no reset of this flag anywhere, hence if a user opens some TS, then kills that client application, then opens it again (with the same or different client app), there is a flood of error messages about TS read underflow. Solution: clear the tx_started flag when the TS is stopped. Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1 --- M src/ctl.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved diff --git a/src/ctl.c b/src/ctl.c index e63589b..a9818b3 100644 --- a/src/ctl.c +++ b/src/ctl.c @@ -119,6 +119,7 @@ ts->raw.rx_buf = NULL; ts->raw.rx_buf_size = 0; ts->raw.rx_buf_used = 0; + ts->raw.tx_started = false; } static void -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1 Gerrit-Change-Number: 37319 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon@freecalypso.org> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-MessageType: merged