Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32988 )
Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue ......................................................................
Patch Set 2:
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/df61f833_b2f972a9 PS2, Line 1891: case PL_DECISION_ACCEPT_ASIS: I'd rather drop the "ASIS" part from here, it is confusing, it looks like some sort of acronym.
File src/common/rtp_input_preen.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/35944902_e579fd72 PS2, Line 37: static bool rtppayload_is_octet_aligned(const uint8_t *rtp_pl, unsigned payload_len) feel free to add "amr_is_octet_aligned" (add "amr") so that it vecomes clearer this is for AMR.