Attention is currently required from: laforge. Hoernchen has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/38003?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Fix building in environments that define _GNU_SOURCE ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: nah. a proper fix ensures this flag never ends up in the cflags in the first place, like URING_CFLAGS=$(echo "$URING_CFLAGS" | sed 's/-D_GNU_SOURCE//g') after pkgconfig adds it -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36cb3a5555cb35ddc44f06d447268bd9cc0ce9b4 Gerrit-Change-Number: 38003 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Tue, 03 Sep 2024 10:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes