Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27935 ) Change subject: paging: Estimate available_slots based on BTS config when no CCCH Load Ind received ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27935/comment/6ecc51e3_5aa06c76 PS3, Line 2344: sd.bts->ccch_load_ind_period
In paging.c you multiply it by 2, but here you don't. Is it intentional? […] Because in this path we know it's an ipaccess BTS which will keep sending CCCH Load Indication all the time despite being under Load Threshold (value UINT16_MAX), so we know we'll receive another CCCH Load Ind after sd.bts->ccch_load_ind_period seconds. Hence, there's no sense in calculating double the time.
sd.bts->ccch_load_ind_period * 2 is used to provide enough time for CCCH Load Ind to arrive if they are delayed. If that bts->ccch_load_ind_period * 2 timeframe is reached, in general we consider the BTS is not sending load indications because it's under threshold. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2df68e10eb549d62765ad3b25429f7fe2d5bb0b9 Gerrit-Change-Number: 27935 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 28 Apr 2022 11:51:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment