Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37895?usp=email ) Change subject: pySim-shell, cosmetic: define positional arguments last ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37895/comment/8b29a5ca_b1d7fa21?usp=ema... : PS1, Line 238: apdu_cmd_parser = argparse.ArgumentParser() is this really a cosmetic change? I would expect that before this change, the --opts would have to come after the APDU, while now they would have to come before the APDU? If this is the case, this would break tons of scripts I have here, e.g. for card personalization. Please verify that this change still accepts the existing/old argument ordering. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2412eb6e7dc32ae95a575f31d4489ce210d85ea0 Gerrit-Change-Number: 37895 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Thu, 22 Aug 2024 10:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes