Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/43637?usp=email
to look at the new patch set (#3).
Change subject: pySim-shell: use verify_adm command for commandline ADM auth ......................................................................
pySim-shell: use verify_adm command for commandline ADM auth
since the very early days, pySim-shell.py has a commandline option where the user may supply an ADM pin as commandline parameter. (-a / --pin-adm and -A --pin-adm-hex) This was introduced to simplify the usage of pySim-shell.py with shellscripts.
Unfortunately the code that handles those commandline options duplicates the code of the verify_adm commmand. Fortunately it is very easy to call pySim-shell commands directly using the CMD2 onecmd_plus_hooks method, so we can just call the verify_adm and replace the duplicated code with that.
So far we are only able to use ADM1 pins from the commandline, since we now practically use the verify_adm commnad, we can add another parameter to allow the verification of ADM as well.
Related: SYS#8239 Change-Id: I7164fad757048774aa7186a84041febde75c351c --- M pySim-shell.py 1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/43637/3