Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email )
Change subject: Introduce osmo-remsim-client-socket ......................................................................
Patch Set 1:
(5 comments)
File src/client/user_socket.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/47f71c96_34c8b636?u... : PS1, Line 15: socklen_t addr_len; code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/e1f8bf31_2912e776?u... : PS1, Line 15: socklen_t addr_len; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/be30840c_7d1024c7?u... : PS1, Line 114: ss->addr_len = sizeof(ss->addr); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/86f21428_13d14c19?u... : PS1, Line 114: ss->addr_len = sizeof(ss->addr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/7e6747e9_a382e3e2?u... : PS1, Line 160: while (1) { braces {} are not necessary for single statement blocks