Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32988 )
Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue ......................................................................
Patch Set 1:
(1 comment)
File src/common/osmux.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/fbb77ce6_fbe05b22 PS1, Line 413: /* We have to apply the same checks as in l1sap_rtp_rx_cb(), in case
yes, it's AMR only. In case you want to know more on the topic: […]
Question: the AMR encoding format check done in rtppayload_is_octet_aligned(), is it needed for Osmux, or only for plain RTP input? The answer to this question will affect the design of my next patch revision: if this logic is not needed for Osmux, the code can be simplified. If it is still needed, it won't be a big difficulty either, I just need to know which way it is.