Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email ) Change subject: osmo-bts-trx: trx_fn_timer_cb(): fix misleading shutdown reason ...................................................................... Patch Set 2: (2 comments) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/ba2d8fa9_2905f34a?usp=... : PS2, Line 414: const char *reason; better NULL it here to avoid some mess in the future if someone changes some code path. https://gerrit.osmocom.org/c/osmo-bts/+/40156/comment/9a9e4f72_86b9b369?usp=... : PS2, Line 454: reason = "PC clock skew"; I'd rather change this to something like "PC clock skew too high". We are not stopping because there was a bit of skew, but because we ended up in some crazy value we cannot recover from. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/40156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibbbbc4e919e6eb812882fc60de4be13fa77934b7 Gerrit-Change-Number: 40156 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 25 Apr 2025 14:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No