Attention is currently required from: laforge, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email )
Change subject: firmware: Implement debug command via USB control vendor class
......................................................................
Patch Set 10:
(1 comment)
File firmware/apps/cardem/main.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/simtrace2/+/43005/comment/0571247b_015a2059?usp... :
PS10, Line 44: void (*ctrl_vendor_req) (const USBGenericRequest *request);
Unnecessary space before function pointer arguments
--
To view, visit
https://gerrit.osmocom.org/c/simtrace2/+/43005?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I1f4d29335eb0d2feef376b8ecdfe57a0162914d6
Gerrit-Change-Number: 43005
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No