Attention is currently required from: Hoernchen, jolly, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email ) Change subject: 7816fsm: Handle unexpected procedure bytes gracefully ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS1:
I didn't bother formatting it because we never commited the updated rules nor the guards around the […] Done
File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776/comment/90ce301f_eed... : PS1, Line 1376: ISO7816_E_TPDU_FAILED_IND
I suggest to introduce a new error event here. […] given that ewild is on holidays fro some time: can you try to do this in an incremental patch yourself, plase?
-- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic53814540775f902fce644a5565a7bd2f177a7fe Gerrit-Change-Number: 42776 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 18 Jun 2026 10:53:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: laforge <laforge@osmocom.org>