Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email ) Change subject: 5gc: Support PDU Session Establishment procedure ...................................................................... Patch Set 6: (6 comments) Patchset: PS6: I'm updating deps/makefile again to contain a couple fixes I submitted upstream here: https://forge.etsi.org/rep/int/5g-core/nas/-/merge_requests/10 File 5gc/C5G_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/e9024638_c6dbf... : PS6, Line 324: log("Rx NAS message: ", rx_nas);
looks unrelated It's not needed anymore, part of this next step towards having steps consolidated.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/38c34695_328d9... : PS6, Line 386: log("Rx inner NAS: ", rx_nas);
looks unrelated It's not needed anymore, part of this next step towards having steps consolidated.
File deps/Makefile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/3e586d33_5bb55... : PS6, Line 74: Do not put references to branches here
This has been removed in a recent commit. Looks like a rebase artifact. Done
File library/NG_NAS_Osmo_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/5bf6294b_7bb31... : PS6, Line 584: omit
How can the whole template be `omit`? It always yields a `value`, right? Done
File library/NG_NAS_Osmo_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/2a9acfab_cb521... : PS6, Line 70: errorbehavior(ALL:WARNING)
Interesting, haven't seen this before. […] No idea, just copied it from the superset union provided in nas.git. I think it sets RAW enc/dec logging to desired level. Removing it since it's not really important here.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8 Gerrit-Change-Number: 40445 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 24 Jul 2025 10:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>