Attention is currently required from: dexter, laforge, neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email )
Change subject: personalization: add param_source.py, add batch.py ......................................................................
Patch Set 10:
(2 comments)
File pySim/esim/saip/batch.py:
https://gerrit.osmocom.org/c/pysim/+/41845/comment/09bb5feb_871482a8?usp=ema... : PS10, Line 68: None I've changed this because several instances of this class may end up modifying the same dict instance, resulting in weird consequences. Typical Python pitfall.
File pySim/esim/saip/param_source.py:
https://gerrit.osmocom.org/c/pysim/+/41845/comment/e77eab95_070c7a83?usp=ema... : PS10, Line 205: val is None Changed to `... is None` to avoid raising exceptions for values like `0` and `False`.