Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27088 ) Change subject: core/utils.h: wrap OSMO_ASSERT() with do { ... } while (0) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/core/utils.h: https://gerrit.osmocom.org/c/libosmocore/+/27088/comment/d567ec77_4cb94df3 PS1, Line 118: } while (0); /* some code invokes OSMO_ASSERT() without the semicolon */ We should fix those. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42d9c315c9c30bce828564a63c496ee62e5c1431 Gerrit-Change-Number: 27088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Feb 2022 10:58:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment