fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email ) Change subject: diameter: assert that diameter:start_service/2 returns ok ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428/comment/5793d589_f... : PS1, Line 11:
Can you use add Fixes: tag like the linux kernel is using? You mean using braces around the commit message in quotes and longer hash? I will be using this next time, didn't know it's well documented in the kernel. Thanks.
-- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Gerrit-Change-Number: 38428 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 15 Oct 2024 16:10:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>