Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email )
Change subject: trxcon/trx_if: refactor the transceiver FSM
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/host/trxcon/src/trx_if.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/43824/comment/2adb730f_60266403?us... :
PS1, Line 868: .action = trx_fsm_poweron_action,
I lack a "st" somewhere so it becomes obvious when seeing the function that it's a state handling one, it happened to me at the start of the file.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I243da047ca606986dbf8ce3cadf69ede4c7227d1
Gerrit-Change-Number: 43824
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 08 Oct 2026 19:35:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes