Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34059 ) Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH ...................................................................... Patch Set 5: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/54c1e438_4bf7177b PS4, Line 14: CAUTION: This patch breaks compatibility to current master osmo-pcu (See : also "Depends")
Normally such breaking changes should be accompanied with the protocol version bump. […] We still have the option to bump the version number in this patch and then in the future apply the policy that the version number must be bumped as soon as a detail in PCUIF changes.
What do you think? Shall we bump the version to v.12 here now (osmo-ttcn3-hacks would require a follow up patch) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/dc7e0a13_2a8ec34f PS4, Line 733: struct bts_agch_msg_cb *msg_cb
const Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I29858fa20ad8bd0aefe81a5c40ad77a2559a8c10 Gerrit-Change-Number: 34059 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 09:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment