Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email )
Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: I tend to agree with the minor improvement requests by lynxis. Would be great if @Hoernchen can review + update.
File firmware/libcommon/source/simtrace_iso7816.c:
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/474e1abc_5d5259e8?usp... : PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) {
It is correct, but because this is a define from ./libchip_sam3s/include/SAM3S. […]
Acknowledged