Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email ) Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I tend to agree with the minor improvement requests by lynxis. Would be great if @Hoernchen can review + update. File firmware/libcommon/source/simtrace_iso7816.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/474e1abc_5d5259e8?usp... : PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) {
It is correct, but because this is a define from ./libchip_sam3s/include/SAM3S. […] Acknowledged
-- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Aug 2026 18:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>