lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: reset tcap.enabled after cleaning ASP up ...................................................................... tcap_as_loadshare: reset tcap.enabled after cleaning ASP up When using static configured ASP, the tcap.enabled flag would be still true when a ASP reconnected without using IPA TCAP commands: client osmo-stp IPA connect -> .. TCAP Add Range -> <- TCAP Ack ... IPA disconnect -> IPA connect -> Without resetting tcap.enabled in the ASP, the IPA client would be TCAP enabled, even when no TCAP Add Range command was used. Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 --- M src/tcap_as_loadshare.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/03/44003/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 8e24882..151766e 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -1098,6 +1098,11 @@ } } +/** Remove an ASP from TCAP loadsharing. Also called when ASP FSM goes down (IPA disconnect) + * + * @param[in] as + * @param[in] asp + */ void tcap_as_del_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp) { if (!asp->tcap.enabled) @@ -1108,6 +1113,8 @@ _tcap_range_asp_down(as, asp); if (as->tcap.contains_pc || as->tcap.contains_ssn) tcap_range_as_update_pc_ssn(as); + + asp->tcap.enabled = false; } void tcap_enable(struct osmo_ss7_as *as) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>