8 Jun
2023
8 Jun
'23
11:19 a.m.
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 ) Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC' ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > (btw, in case it is interesting to know why this occurs / to explain that this is not meant to ignor […] No worries, I was not thinking you were explicitly ignoring the comments. I write "not yet addressed" because it has several benefits: - Remark it in case you didn't see it / forgot about it - Remind me of the last review state after I re-review it, and for others to see that there's still stuff not done. In any case, I'd welcome if you could as much as possible fix all the comments before pushing a new version, since that means I don't need to do several rounds of review. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a Gerrit-Change-Number: 33178 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 09:19:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment