Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/42839?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: client: fix off-by-one in wrapped pcap stats counter ...................................................................... client: fix off-by-one in wrapped pcap stats counter When a libpcap stats counter (ps_recv/ps_drop/ps_ifdrop) wraps around UINT_MAX, get_psbl_wrapped_ctr() computed the delta as (UINT_MAX - old_val) + new_val, omitting the single increment that takes the counter from UINT_MAX through zero. Add the missing +1 so the reported delta matches the real number of increments. Change-Id: I66581910dbd1e955831a6ff913042059ad4994a7 AI-Assisted: yes (Claude) --- M src/osmo_client_core.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/39/42839/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I66581910dbd1e955831a6ff913042059ad4994a7 Gerrit-Change-Number: 42839 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>