Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email )
Change subject: library: add f_gsm_fn_{sum,sub,diff}()
......................................................................
Patch Set 2:
(1 comment)
File library/GSM_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915/comment/52eeaf5b_1e3b1... :
PS2, Line 450: function f_gsm_fn_diff(GsmFrameNumber a, GsmFrameNumber b) return GsmFrameNumber {
Acknowledged
This API mimics what we have in libosmocore's gsm0502.h. I don't see anything wrong with having this function here, despite it's not used (yet). It's just a few lines - definitely not a big maintenance burden.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42915?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie91ccef5d3f170f4a341a6cf9d3323a896b299e6
Gerrit-Change-Number: 42915
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 02 Jul 2026 20:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
