Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31850 ) Change subject: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63) ...................................................................... Patch Set 1: (6 comments) File src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4992): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/3caa368a_07cbbb9a PS1, Line 67: uint8_t rxlev, uint8_t num_biterr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4992): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/a36cf8c6_49a7c564 PS1, Line 67: uint8_t rxlev, uint8_t num_biterr, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4992): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/ef4e4dd1_f404f6d7 PS1, Line 72: uint8_t rxlev, uint8_t num_biterr, code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4992): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/e2c3ee05_4ad7b45e PS1, Line 72: uint8_t rxlev, uint8_t num_biterr, please, no spaces at the start of a line File src/host/virt_phy/src/virt_prim_data.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4992): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/274ff5f7_57ad6290 PS1, Line 81: uint8_t rxlev, uint8_t num_biterr, uint8_t fire_crc) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4992): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/204e0e40_3d055f42 PS1, Line 81: uint8_t rxlev, uint8_t num_biterr, uint8_t fire_crc) please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec Gerrit-Change-Number: 31850 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 11 Mar 2023 19:36:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment