25 Jan
2023
25 Jan
'23
9:10 a.m.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31020 ) Change subject: lint: enable BRACES_NOT_NECESSARY check ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Not sure if it suits our processes to answer here, but since I didn't see a specific issue for this: […] The checkpatch script we use comes from the linux kernel. So far we've only made adjustments if * it's a trivial change (e.g. of the error string), or * to fix complaints that shouldn't be an error in the Osmocom code bases, e.g. https://gerrit.osmocom.org/c/osmo-ci/+/24918 Other than that we only do config changes to enable / disable existing checks as in this patch. Developing entire new checks is a bit of work and doesn't seem like a good use of time, unless they would save us a lot of trouble down the road. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I481d1b24a909173520a544ffd567bb8357729f2a Gerrit-Change-Number: 31020 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: arehbein <arehbein@sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jan 2023 08:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Gerrit-MessageType: comment