fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email ) Change subject: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38510/comment/76491e0a_f12a706f?usp=... : PS1, Line 7: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
I would avoid the use of "cosmetic" in this patch, since it's really changing the output binary most […] It does not change the way this function behaves though. Strictly speaking, even removing an empty line will result in different binary output at least because line numbers in logging will be different... Anyways, will use "coding style changes" next time to avoid philosophical discussions.
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9 Gerrit-Change-Number: 38510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>