pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27597 ) Change subject: libosmocore.pc.in: put libsctp in Requires.private ...................................................................... libosmocore.pc.in: put libsctp in Requires.private The libsctp use in libosmocore is internal, not exposed to applications. Hence, it must not be in "Requires" but in "Requires.private". Fixes: 12eed19066a11aece6f346b54b85326bc6ba7f0b Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 --- M libosmocore.pc.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/libosmocore.pc.in b/libosmocore.pc.in index 3bb9b9a..6296417 100644 --- a/libosmocore.pc.in +++ b/libosmocore.pc.in @@ -6,7 +6,8 @@ Name: Osmocom Core Library Description: C Utility Library Version: @VERSION@ -Requires: talloc, libsctp +Requires: talloc +Requires.private: libsctp Libs: -L${libdir} -losmocore Libs.private: @PTHREAD_LIBS@ Cflags: -I${includedir}/ @PTHREAD_CFLAGS@ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic3e4e191990e6b76ec52b81e506b49980e20ce20 Gerrit-Change-Number: 27597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged