Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email )
Change subject: global_platform: install_cap_parser: argument groups cannot be nested ......................................................................
Patch Set 3: Code-Review+1 Verified+1
(2 comments)
Patchset:
PS3: This is not perfect yet. Nothing bad happens and everything still works but maybe there are users that believe they can pass a half baked --install-parameter hexstring and use --install-parameter-stk to add STK parameters. That would not work of course.
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42310/comment/27682eb8_69b8aea1?usp=ema... : PS3, Line 898: if opts.install_parameters is not None: Now there is no check that makes sure that none of the opts.install_parameters_* is set. This means that when someone passes --install-parameters xyz in addition with for e.g. --install-parameters-volaitile-memory-quota 1234, the --install-parameters-volaitile-memory-quota parameter gets silently ignored.