Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: add routing areas ......................................................................
Patch Set 5:
(8 comments)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/d37195e3_4e284ed5?usp... : PS5, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) {
space required before the open parenthesis '('
This one needs to be fixed. This is a for, not a function, we use a space.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/e6f9799c_c08abc7a?usp... : PS5, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list)
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/6ffd4f35_9297c05d?usp... : PS5, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/12f0dedb_4b5b55a0?usp... : PS5, Line 112: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c9088e09_c5ed2425?usp... : PS5, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) {
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/7233e648_20f63a33?usp... : PS5, Line 164: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3eec4153_e53da15e?usp... : PS5, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/86e36923_c564dc6e?usp... : PS5, Line 183: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Please fix.