Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27217 ) Change subject: libosmo-tlv: add versatile TLV de- and encoder ...................................................................... Patch Set 3: (1 comment) Patchset: PS3:
as a general rule we don't introduce symbols or types with an osmo_ prefix into applications. […] the osmo_prefix: for a long time i "knew" that the osmo_ prefix is only added in libosmocore. Then some years ago i learnt that a libxxx does get the osmo prefix also when not in libosmocore.git, like osmo_ss7_* from osmo-iuh.git or osmo_gsup_* from osmo-hlr.git. I added the osmo_ prefix because the intention is that this is an independent lib. And, yes, if it proves useful the idea is to move it to libosmocore.git.
naming ideas: osmo_utlv as in "universal" osmo_gtlv as in "generic" or "generated" osmo_tlv2_* i think i like 'g' -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Mon, 21 Mar 2022 16:58:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment