Attention is currently required from: pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 3: (4 comments) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/c37a6736_95fcdb80?usp=... : PS1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] =
WIP I guess. I'm not really sure what statements might up end being wanted. […] Done
File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/56fa6d48_3a7557b8?usp=... : PS1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */
The db code contains similar "hacks" to have the tests pass. […] Done
https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/9d5d1d91_f53f95bf?usp=... : PS1, Line 873: db_sms_mark_delivered(sms);
Sounds like all this should be placed wherever S_SMS_DELIVERED signal is handled imho. Done
File src/libmsc/sms_queue.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/b9a4f25c_2bc10ab5?usp=... : PS1, Line 607: /* Remember the subscriber and clear the pending entry */
The cod eblock should be mover over here? Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 10 Oct 2025 21:22:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: keith <keith@rhizomatica.org>