neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688 ) Change subject: drop bogus error log 'no MGW fsm' ...................................................................... drop bogus error log 'no MGW fsm' Looking at a customer's log, these error logs got my attention. There seems to be no point in logging this at all. Change-Id: I89dd4fb6913bfb84b6667b159e09968734e2102a --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index b58d01f..656066b 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -782,10 +782,8 @@ * \returns 0 on success; negative on error. */ int mgw_fsm_release(struct hnbgw_context_map *map) { - if (!map->mgw_fi) { - LOGP(DMGW, LOGL_ERROR, "mgw_fsm_release() rua_ctx_id=%d, no MGW fsm -- ignored!\n", map->rua_ctx_id); + if (!map->mgw_fi) return -EINVAL; - } osmo_fsm_inst_dispatch(map->mgw_fi, MGW_EV_RELEASE, NULL); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/30688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I89dd4fb6913bfb84b6667b159e09968734e2102a Gerrit-Change-Number: 30688 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged