Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support ......................................................................
Patch Set 14:
(11 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/4c4251d4_c875ea30?usp=... : PS14, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/bef8c136_54a26538?usp=... : PS14, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/fd5a2644_dc403ce3?usp=... : PS14, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2aa25e5f_6afce343?usp=... : PS14, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/769dedc9_d9014aaf?usp=... : PS14, Line 271: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/c593fd7e_e09db41c?usp=... : PS14, Line 272: @param chan channel number please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/0da03343_dbbe50f2?usp=... : PS14, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/40b7def4_14d68ef0?usp=... : PS14, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3bbbfb12_4b8f708f?usp=... : PS14, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line
File Transceiver52M/radioInterface.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/1acdf759_69917528?usp=... : PS14, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/42d14bdd_c341db88?usp=... : PS14, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line