Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email ) Change subject: fixup for re-est: do not succeed on acceptance fail ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/36520/comment/75f1c51f_e5e2f42d PS1, Line 18: Related: SYS#5130
never seen this header pointing at a commit hash before. "Fixes:" is about issue numbers. […] This is super usual in projects such as linux kernel, see:
git log | grep "^Fixes: " This is useful to programatically find fixes for a commit you are eg. cherry-picking into another (stable) branch. I tend to use it when I'm fixing some bug and the patch causing it is known. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3679162143e8d7d8c0878de2102faa11eadfccfc Gerrit-Change-Number: 36520 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 04 Apr 2024 11:03:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment