Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40698?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... Patch Set 2: (2 comments) File include/osmocom/sgsn/mmctx.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/40698/comment/3a5a1079_e84a387b?usp... : PS1, Line 236: ue->conn_id
Yes please @lynxis@fe80.eu edit this patch and add the parenthesis. Acknowledged
https://gerrit.osmocom.org/c/osmo-sgsn/+/40698/comment/e89d4df8_7e427b84?usp... : PS1, Line 238: {}
We tend to do this null case as a "(ue) ? foo : bar". […] Acknowledged
-- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 40698 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 09:42:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>