Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42552?usp=email )
Change subject: filesystem: edit_{binary,record}_decoded: add encode/decode examples ......................................................................
Patch Set 5:
(2 comments)
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/42552/comment/0ed8bc06_4d45922a?usp=ema... : PS4, Line 575: return '\n'.join(line for line in text.splitlines() if not line.lstrip().startswith('//'))
I wonder if this could be improved. […]
Added a TODO.
https://gerrit.osmocom.org/c/pysim/+/42552/comment/f27075a9_1aa09a1a?usp=ema... : PS4, Line 604: with open(filename, 'w') as text_file:
Just an idea: What about adding a line like "//EF. […]
Done