Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email )
Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ......................................................................
Patch Set 2:
(6 comments)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/791e0574_7c9cbc32?usp... : PS2, Line 1645: osmo_routing_area_id_decode(&old_ra_id, cur, msgb_l3len(msg) - 3);
where does the 3 come from? "cur - gh" ?
Yes, "cur - gh" -> this will be replace soon anyways by a commit already in my osmo-sgsn routing-area branch.
Fixed it.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/1c6c79ab_a3778634?usp... : PS2, Line 1729: bssgp_parse_cell_id2(&new_ra_id, NULL, msgb_bcid(msg), 8);
isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bo […]
msgb_bcid(msg) points to the control buffer msgb->cb[0] which is a unsigned long cb[5].
https://gitea.osmocom.org/osmocom/libosmocore/src/branch/master/include/osmo...
https://gitea.osmocom.org/osmocom/libosmocore/src/branch/master/include/osmo...
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/6b6e15b4_91e9cd4a?usp... : PS2, Line 1772: bssgp_parse_cell_id2(&mmctx->ra, NULL, msgb_bcid(msg), 8);
isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bo […]
see earlier comment
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/3046b002_c37e80bd?usp... : PS2, Line 2346: bssgp_parse_cell_id2(&ra_id, NULL, msgb_bcid(msg), 8);
isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bo […]
see earlier comment
File src/sgsn/gprs_sndcp.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/5581b1d1_fe9068a3?usp... : PS2, Line 837: bssgp_parse_cell_id2(&sne->ra_id, NULL, msgb_bcid(msg), 8);
same
Done
File src/sgsn/gprs_subscriber.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/6c53a818_5be0f95f?usp... : PS2, Line 880: if (subscr->lac != mmctx->ra.lac.lac)
we should add a define to name "lac" as "lai" in that struct :)
true! but no in this commit ;)