Attention is currently required from: jolly, lynxis lazus. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email ) Change subject: Add optional timeout to mapping ...................................................................... Patch Set 6: (4 comments) File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/f918aa62_62f41c3a?u... : PS6, Line 415: { Add some logging regarding the timeout her? https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/78449393_d430d813?u... : PS6, Line 463: osmo_timer_setup(&map->timer, mapping_timeout, map); This timer/timeout looks really related to the "map" object, not the "conn" one, which means this timer most probably belongs to the FSM/file in map->state? (The one doing stuff with slotmap_state_change()?) https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/b162fb17_10a923a5?u... : PS6, Line 464: osmo_timer_schedule(&map->timer, map->timeout, 0); if map->timeout > 0 File src/slotmap.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/8c534e4b_4e9b6aa4?u... : PS6, Line 174: osmo_timer_del(&map->timer); There we go, the timer is deleted here, so the set up of the timer and arming it also probably belngs in this file or wherever its FSM is. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2f7ee24e6c926b65876af2b14da3534555398769 Gerrit-Change-Number: 43746 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 11 Nov 2026 11:02:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No