Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381?usp=email ) Change subject: library/GTPv1U_Templates: support sending ext hdrs ...................................................................... Patch Set 2: (1 comment) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381/comment/ba9f4c75_502f8... : PS1, Line 402: var template (omit) GTPU_Header_optional_part opt_part;
afaiu you are missing an ":= omit" here, otherwise you pass uninitialized value in line 409 when !us […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5b1668d45f4454f92c234054678e17145bd4fe49 Gerrit-Change-Number: 38381 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 08:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>