28 May
2026
28 May
'26
3:51 p.m.
Attention is currently required from: laforge, lynxis lazus.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email )
Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/9322de58_828c57... : PS8, Line 263: if (assoc && osmo_ss7_asp_active(assoc->asp) && assoc->asp->tcap.enabled) { I'm personally in favor of braces around single-statement blocks, but I think this goes against our coding style.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd
Gerrit-Change-Number: 42760
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 28 May 2026 08:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes