Attention is currently required from: pespin, fixeria, dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32740 )
Change subject: gsm620: make osmo_hr_check_sid compatible with RFC 5993 ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS1:
I was thinking about normalizing the to one format at the beginning but I quickly realized that this […]
@dexter - please read my notes under the Redmine ticket for OS#5688. With my proposed solution, there won't be any double conversion like you are talking about - not just "often", but never at all. Also if OS#5688 ends up being "solved" the way you are going about it, I will never be able to implement OS#6036, and I won't be able to add HR1 support to OS#5996 - the issue that originally prompted you to create the present patch.
I vote in strongest possible terms for leaving the osmo_hr_check_sid() function as it currently is.
Also how urgent is this OS#5688 bug? If the issue isn't an urgent one, and we have a disagreement about how to approach it, perhaps we can pause any code-change actions until we discuss it in June OsmoDevCall? My original plan was to focus on FR1 and EFR there, but I have now studied up on HR1 too, and given that deciding on the way to handle HR1 is an active open issue, I now plan on discussing HR1 extensively too, both OS#5688 and OS#6036.