mobile: config file in /etc/osmocom/osmocom.cfg
Hi all, I would like to propose moving the config file into something like ~/.osmocom/ and not put it in a system wide directory. The path in /etc/ is the only part of OsmocomBB that requires root privileges, and I don't really think that in a case of multiple users you would want to e.g. share stuff like the IMSI / Ki anyway. What do you think? -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Harald Welte wrote:
I would like to propose moving the config file into something like ~/.osmocom/ and not put it in a system wide directory. The path in /etc/ is the only part of OsmocomBB that requires root privileges, and I don't really think that in a case of multiple users you would want to e.g. share stuff like the IMSI / Ki anyway.
What do you think?
Acked-by: Peter Stuge <peter@stuge.se>
Hi, On 01/29/2011 07:18, Harald Welte wrote:
I would like to propose moving the config file into something like ~/.osmocom/ and not put it in a system wide directory. The path in /etc/ is the only part of OsmocomBB that requires root privileges, and I don't really think that in a case of multiple users you would want to e.g. share stuff like the IMSI / Ki anyway.
What do you think?
I'm ok too, with a patch attached. HTH, -- khorben
On 01/29/2011 13:56, Pierre Pronchery wrote:
I'm ok too, with a patch attached.
It was missing two additional #include. For the record, when I implement this I usually fallback on glib's g_get_home_dir() in case getenv() fails. It typically uses getpwuid(getuid()) on *nix, but I suppose it'd be a bit overkill here :) HTH, -- khorben
Hi khorben,
It was missing two additional #include.
after some delay, I took the liberty of applying your patch to master, adding the followign changes: * coding style "if(" vs "if (" * use .osmocom/bb/mobile.cfg instead of .osmocom * use talloc instead of malloc -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (3)
-
Harald Welte -
Peter Stuge -
Pierre Pronchery