Re: [PATCH OSMOCOM-BB] src: use new libosmogsm and include/osmocom/[gsm|core] path to headers
Hi Pablo, On Tue, Mar 22, 2011 at 05:16:58PM +0100, pablo@gnumonks.org wrote:
This patch also renames hexdump in osmocon.c and osmoload.c to avoid clashing with hexdump defined in libosmocore. This is a workaround, it's planned to fix the namespace pollution of the library soon.
how did you test this patch? Did you first update the libosmocore copy inside osmocom-bb.git using 'git-subtree', and then apply + test your patch? Did you make sure that new libosmocore will also build using the cross-compiler for the phone firmware (see + use the osmocom-bb/src/Makefile) ? Also, for the future: please note the mailing list for osmocom-bb is 'baseband-deve@lists.osmocom.org', not the openbsc list... Thanks, Harald -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Hi Harald, On 23/03/11 18:39, Harald Welte wrote:
Hi Pablo,
On Tue, Mar 22, 2011 at 05:16:58PM +0100, pablo@gnumonks.org wrote:
This patch also renames hexdump in osmocon.c and osmoload.c to avoid clashing with hexdump defined in libosmocore. This is a workaround, it's planned to fix the namespace pollution of the library soon.
how did you test this patch? Did you first update the libosmocore copy inside osmocom-bb.git using 'git-subtree', and then apply + test your patch?
I compiled it, only compile-tested. I got an openmoko phone so now I'll be able to perform further testing.
Did you make sure that new libosmocore will also build using the cross-compiler for the phone firmware (see + use the osmocom-bb/src/Makefile) ?
Yes, I modified the Makefile to get it working with the new changes.
Also, for the future: please note the mailing list for osmocom-bb is 'baseband-deve@lists.osmocom.org', not the openbsc list...
I see I'll use the appropriate mailing list next time, sorry.
participants (2)
-
Harald Welte -
Pablo Neira Ayuso