[PATCH 5/5] Change internal API for consistency

Max msuraev at sysmocom.de
Tue Apr 26 11:14:54 UTC 2016


Thanks. Comments are inline.

On 04/26/2016 01:06 PM, Neels Hofmeyr wrote:
> On Thu, Apr 21, 2016 at 02:35:57PM +0200, msuraev at sysmocom.de wrote:
>> -	void *priv;			/* user reference */
>> +	uint8_t trx;
> So I presume you are certain that priv was so far only used for the trx
> number, that there are no other callers using priv, and that it makes
> sense to not have a priv pointer anymore?

Yes.

> Looking at the patch it does look like priv was never really a priv in the
> arbitrary-backpointer case, but IMHO it would be good to clarify that in
> the log message.
>
>> -	int rc = 0;
>> -	int trx, ts;
>> -	int i;
>> +	int rc = 0, ts, i;
> Unrelated cosmetic change, keep that out of this patch, i.e. only remove
> the trx int, the point being that I noticed only on the second glance.

Noted.

> Also I believe we prefer to have each variable on its own line.
>
It doesn't look that way from looking at the other code. It also
decreases readability by cluttering the code with useless repetitions.

-- 
Max Suraev <msuraev at sysmocom.de> http://www.sysmocom.de/
======================================================================= 
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93 
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B 
* Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte 



More information about the osmocom-net-gprs mailing list