[PATCH 5/5] Change internal API for consistency

Neels Hofmeyr nhofmeyr at sysmocom.de
Tue Apr 26 11:06:59 UTC 2016


On Thu, Apr 21, 2016 at 02:35:57PM +0200, msuraev at sysmocom.de wrote:
> -	void *priv;			/* user reference */
> +	uint8_t trx;

So I presume you are certain that priv was so far only used for the trx
number, that there are no other callers using priv, and that it makes
sense to not have a priv pointer anymore?

Looking at the patch it does look like priv was never really a priv in the
arbitrary-backpointer case, but IMHO it would be good to clarify that in
the log message.

> -	int rc = 0;
> -	int trx, ts;
> -	int i;
> +	int rc = 0, ts, i;

Unrelated cosmetic change, keep that out of this patch, i.e. only remove
the trx int, the point being that I noticed only on the second glance.
Also I believe we prefer to have each variable on its own line.

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/osmocom-net-gprs/attachments/20160426/22772643/attachment.bin>


More information about the osmocom-net-gprs mailing list