[PATCH 5/5] Change internal API for consistency

Neels Hofmeyr nhofmeyr at sysmocom.de
Thu Apr 28 11:31:09 UTC 2016


On Tue, Apr 26, 2016 at 01:14:54PM +0200, Max wrote:
> > Also I believe we prefer to have each variable on its own line.
> >
> It doesn't look that way from looking at the other code. It also
> decreases readability by cluttering the code with useless repetitions.

but removing/adding variables where there are more than one per line makes
the patches less readable, and potentially introduces more merge conflicts
than necessary...

I used to be against one-per-line but have changed my opinion quite some
time ago :)

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/osmocom-net-gprs/attachments/20160428/77d039b2/attachment.bin>


More information about the osmocom-net-gprs mailing list