osmo-pcu.git branch jolly updated. f3d060c6310bfa979225b871ba463284d3cda887

Alexander Chemeris alexander.chemeris at gmail.com
Thu Jul 5 16:46:55 UTC 2012


Hi Andreas,

I've looked through your commits and looks like you're doing a very
quick progress. Your changes are overlapping with Ivan's work and I
would recommend to merge them the master as often as possible to avoid
duplicated efforts and code divergence. From this quick review I've
got impression that code needs clean up before the merge, so it would
be good if you share your plans on this.

As a general comment, I think we could do merging of your code into
master, but it would be much, much easier if you commit in smaller
"atomic" chunks. E.g. these two last commits contain more changes then
is written in the commit logs and in my opinion should be splitted
into several independent commits.

Note, that I just want to share my opinion and it's up to you and Ivan
to decide how to work together efficiently.

On Thu, Jul 5, 2012 at 6:42 AM, git repository hosting
<gitosis at osmocom.org> wrote:
> This is an automated email from the git hooks/post-receive script. It was
> generated because a ref change was pushed to the repository containing
> the project "UNNAMED PROJECT".
>
> The branch, jolly has been updated
>        via  f3d060c6310bfa979225b871ba463284d3cda887 (commit)
>        via  06b195e43e36c0b5100ab03e80fcc87a10db9fc5 (commit)
>       from  e6228b34a75efcb6b0700ac29672d62539860fbf (commit)
>
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email; so we list those
> revisions in full, below.
>
> - Log -----------------------------------------------------------------
> http://cgit.osmocom.org/cgit/osmo-pcu/commit/?id=f3d060c6310bfa979225b871ba463284d3cda887
>
> commit f3d060c6310bfa979225b871ba463284d3cda887
> Author: Andreas Eversberg <jolly at eversberg.eu>
> Date:   Thu Jul 5 07:38:49 2012 +0200
>
>     Fixed pseudo length of IMMEDIATE ASSIGNMENT message.
>
>     The pseudo length may not include the rest-octets, so it stays compatible
>     to non-GPRS phones.
>
>     At pcu_l1_if.c (OpenBTS) no pseudo length is given, so the frame is
>     only 22 bytes long. I could not test if it works.
>
> http://cgit.osmocom.org/cgit/osmo-pcu/commit/?id=06b195e43e36c0b5100ab03e80fcc87a10db9fc5
>
> commit 06b195e43e36c0b5100ab03e80fcc87a10db9fc5
> Author: Andreas Eversberg <jolly at eversberg.eu>
> Date:   Thu Jul 5 07:34:29 2012 +0200
>
>     Use cell informations received from PCU socket interface
>
>     Cell info is received from socket interface. The given parameters are
>     used to replace the hardcoded values (at least for l1 socket interface).
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  configure.ac             |    8 ++
>  src/Makefile.am          |   19 ++----
>  src/gprs_bssgp_pcu.cpp   |  178 ++++++++++++++++++++++++++++++++++++++++++++--
>  src/gprs_bssgp_pcu.h     |   24 ++----
>  src/gprs_debug.cpp       |    2 +-
>  src/gprs_rlcmac.cpp      |   41 ++++++-----
>  src/gprs_rlcmac.h        |   25 ++++---
>  src/gprs_rlcmac_data.cpp |   79 +++++++++++++-------
>  src/pcu_l1_if.cpp        |   37 +++++++++-
>  src/pcu_main.cpp         |  123 ++++++++++++++++++--------------
>  src/sysmo_l1_if.cpp      |   94 ++++++++++++++++++++++---
>  11 files changed, 471 insertions(+), 159 deletions(-)
>
>
> hooks/post-receive
> --
> UNNAMED PROJECT
>



-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves LLC / ООО УмРадио
http://fairwaves.ru




More information about the osmocom-net-gprs mailing list